include Typography utility class names in documentation for easier reference #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ference ## Context Whenever I look up typography utility classes, I end up having to inspect the markup in the embedded Storybook to get the actual class name. It would be much easier if the class names were written out in the documentation instead, so they could be copy/pasted directly from the page, without having to take the extra step of inspecting the page source. ## Summary This PR adds the class names to the documentation. I'm opening a separate PR to add them within the storybooks as well.
ktravers
added a commit
to primer/css
that referenced
this pull request
Jun 1, 2024
## Context Whenever I look up typography utility classes, I end up having to inspect the markup in the embedded Storybook to get the actual class name. It would be much easier if the class names were written out in the text content instead, so they could be copy/pasted directly from the page, without having to take the extra step of inspecting the page source. ## Summary This PR adds the class names to the storybook text content. ## Related primer/design#796
1 task
langermank
pushed a commit
to primer/css
that referenced
this pull request
Jun 3, 2024
## Context Whenever I look up typography utility classes, I end up having to inspect the markup in the embedded Storybook to get the actual class name. It would be much easier if the class names were written out in the text content instead, so they could be copy/pasted directly from the page, without having to take the extra step of inspecting the page source. ## Summary This PR adds the class names to the storybook text content. ## Related primer/design#796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Whenever I look up typography utility classes, I end up having to inspect the markup in the embedded Storybook to get the actual class name. It would be much easier if the class names were written out in the documentation instead, so they could be copy/pasted directly from the page, without having to take the extra step of inspecting the page source.
Summary
This PR adds the class names to the documentation. I tried to maintain consistency with how class names are already referenced elsewhere in the doc (ex. header class names).
Related
primer/css#2633