feat(FormControl): Promote FormControl to CSS modules GA feature flag #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f639d48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
hussam-i-am
approved these changes
Mar 5, 2025
jonrohan
reviewed
Mar 7, 2025
There was a problem hiding this comment.
At this point this is the only component left not in ga. Seems like we could just go ahead and include in the latest #5717
But gonna leave that up to @francinelucca as RC
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@primer/react": minor | |||
There was a problem hiding this comment.
Suggested change
| "@primer/react": minor | |
| "@primer/react": patch |
Been tagging these changes as patch
|
Go for it 🔥 |
francinelucca
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/github/primer/issues/3812
Changelog
New
Changed
FormControl feature flag is promoted to GA
Removed
Rollout strategy
Testing & Reviewing
Merge checklist