Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogV2: Reduce the buttons in Storybook story #5740

Merged
merged 2 commits into from
Mar 8, 2025

Conversation

TylerJDev
Copy link
Member

Reduces the amount of buttons in our "Stress Test" story, so that the dialog always retains enough space for each section (header, body, footer).

Supplements #5629

Changelog

Changed

  • Reduces amount of buttons in "Stress Test" story, from 10 to 3.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@TylerJDev TylerJDev requested a review from francinelucca March 6, 2025 15:24
@TylerJDev TylerJDev requested a review from a team as a code owner March 6, 2025 15:24
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: 55ac8eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Mar 6, 2025
@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Mar 6, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.94 KB (0%)
packages/react/dist/browser.umd.js 106.3 KB (0%)

@francinelucca
Copy link
Member

I'm confused on this one 😅 . Can you add more context as to why this is needed? I see in the snapshots all the buttons fit in the original, is this to accommodate for #5629 ? If so can you elaborate on the issue it's solving for? 🙏

@TylerJDev
Copy link
Member Author

@francinelucca, the dialog's body isn't visible if the height/width is too small. For example, at 320 x 312, the body itself isn't accessible. #5629 enhances this by having the buttons placed in the footer horizontally rather than vertically. We can still present this story as a stress test, but reduce the amount of buttons, as we probably wouldn't want consumers to use more than 2-3 buttons at a given time in a footer 😅

More context is in this issue: https://github.com/github/accessibility-audits/issues/10071

Also attached an image of how it looks with a smaller screen size.

Screen capture of Dialog component stress test story, that shows stacked buttons in the dialogs footer, which prevents the dialog body from being shown

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context! 💃

@TylerJDev TylerJDev added this pull request to the merge queue Mar 8, 2025
Merged via the queue into main with commit 4691b9f Mar 8, 2025
44 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/dialog-stress-test-fix branch March 8, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants