-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DialogV2: Reduce the buttons in Storybook story #5740
Conversation
|
size-limit report 📦
|
I'm confused on this one 😅 . Can you add more context as to why this is needed? I see in the snapshots all the buttons fit in the original, is this to accommodate for #5629 ? If so can you elaborate on the issue it's solving for? 🙏 |
@francinelucca, the dialog's body isn't visible if the height/width is too small. For example, at 320 x 312, the body itself isn't accessible. #5629 enhances this by having the buttons placed in the footer horizontally rather than vertically. We can still present this story as a stress test, but reduce the amount of buttons, as we probably wouldn't want consumers to use more than 2-3 buttons at a given time in a footer 😅 More context is in this issue: https://github.com/github/accessibility-audits/issues/10071 Also attached an image of how it looks with a smaller screen size. ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the context! 💃
Reduces the amount of buttons in our "Stress Test" story, so that the dialog always retains enough space for each section (header, body, footer).
Supplements #5629
Changelog
Changed
Rollout strategy
Testing & Reviewing
Merge checklist