Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user red focus state for inputs when in error state #5742

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Mar 7, 2025

Changelog

Changed

  • Update TextInputWrapper focus state to use red outline instead of blue when focused on error state
  • Update snapshots

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

See
https://primer-1e0205ec49-13348165.drafts.github.io/storybook/?path=/story/components-formcontrol--playground&args=variant:error
https://primer-1e0205ec49-13348165.drafts.github.io/storybook/?path=/story/components-textinput--playground&args=validationStatus:error
https://primer-1e0205ec49-13348165.drafts.github.io/storybook/?path=/story/components-textarea--playground&args=validationChildren:dd

Merge checklist

@francinelucca francinelucca requested a review from mperrotti March 7, 2025 04:15
@francinelucca francinelucca requested a review from a team as a code owner March 7, 2025 04:15
Copy link

changeset-bot bot commented Mar 7, 2025

🦋 Changeset detected

Latest commit: 78e1778

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@francinelucca francinelucca requested a review from joshblack March 7, 2025 04:16
Copy link
Contributor

github-actions bot commented Mar 7, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.02 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 106.39 KB (-0.04% 🔽)

@github-actions github-actions bot requested a deployment to storybook-preview-5742 March 7, 2025 04:19 Abandoned
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/365860

@github-actions github-actions bot temporarily deployed to storybook-preview-5742 March 7, 2025 04:33 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 7, 2025
"@primer/react": patch
---

fix: user red focus state for inputs when in error state
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fix: user red focus state for inputs when in error state
fix: use red focus state for inputs when in error state

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Mar 8, 2025
Copy link
Contributor

github-actions bot commented Mar 8, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 8, 2025
@francinelucca francinelucca added this pull request to the merge queue Mar 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants