Skip to content

Conversation

liuliu-dev
Copy link
Contributor

@liuliu-dev liuliu-dev commented Oct 16, 2025

Closes #5301

Removed deprecated underline prop from Link component.

Breaking Change: There are a few places including github-ui are still using Link with underline prop: https://primer-query.githubapp.com/?query=Link+attribute%3A%22underline%22+value%3A%22true%22

Migration: Use the inline prop instead to control underline behavior for links.

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Oct 16, 2025

🦋 Changeset detected

Latest commit: 7698bc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 16, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@liuliu-dev liuliu-dev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 16, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-7021 October 16, 2025 20:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants