Closed
Conversation
pimeys
reviewed
Dec 1, 2021
Contributor
pimeys
left a comment
pimeys
left a comment
There was a problem hiding this comment.
Some validation of input values, so fail gracefully if giving negative values from the client.
| opt-level = 'z' # Optimize for size. | ||
| #strip="symbols" | ||
|
|
||
| [patch."https://github.com/prisma/quaint"] |
Contributor
There was a problem hiding this comment.
reminder to remove this before merging
| PrismaValue::Float(value) => ast::Expression::NumericValue(value.to_string(), ast::Span::empty()), | ||
| PrismaValue::Int(value) => ast::Expression::NumericValue(value.to_string(), ast::Span::empty()), | ||
| PrismaValue::BigInt(value) => ast::Expression::NumericValue(value.to_string(), ast::Span::empty()), | ||
| PrismaValue::UnsignedInt(value) => ast::Expression::NumericValue(value.to_string(), ast::Span::empty()), |
Contributor
There was a problem hiding this comment.
UInt, but choose whatever you wish.
garrensmith
force-pushed
the
unsigned-integer-support
branch
from
68d22eb to
7c4f5e7
Compare
Contributor
The QE has no idea about native types, we can't validate that. |
dpetrick
approved these changes
Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this work is based off the work in the quaint project prisma/quaint#335
It is not ready to be merged until the quaint PR has been merged.
At this stage we don't really support unsigned integers so we try and convert it to a signed int. An error is returned if that fails.