feat(schema-engine-wasm): stable skeleton + playground #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with JS object via tsify. Fix build.sh script
CodSpeed Performance ReportMerging #5111 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
jkomyno
commented
Jan 10, 2025
There was a problem hiding this comment.
TODO: delete once somebody reviews this PR.
jkomyno
commented
Jan 10, 2025
|
|
||
| console.log('[adapter]', adapter) | ||
|
|
||
| // TODO: use `engine`. |
There was a problem hiding this comment.
Note: TODOs in the TypeScript files changed/introduced by this PR are supposed to be tackled in later PRs.
For now, they act as informative comments only.
jkomyno
commented
Jan 10, 2025
Comment on lines
+4
to
+5
| # Note: this script started as a copy of the `query-engine-wasm`'s `build.sh` script, but will likely diverge over time. | ||
| # For this reason, we're avoiding premature refactoring and keeping the two scripts separate. |
jkomyno
commented
Jan 10, 2025
Comment on lines
+53
to
+58
| #[derive(Deserialize, Tsify)] | ||
| #[tsify(from_wasm_abi)] | ||
| pub struct SchemaEngineParams { | ||
| // TODO: support multiple datamodels | ||
| datamodel: String, | ||
| } |
There was a problem hiding this comment.
Without tsify::Tsify, this Rust struct would be converted into a (useless) class instance with related class checks.
It's much more ergonomic to pass un-named JS objects as the SchemaEngine's constructor input arguments instead.
jacek-prisma
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: