Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract sql query builder #5123

Open
wants to merge 14 commits into
base: compiler
Choose a base branch
from

Conversation

jacek-prisma
Copy link
Contributor

Extracts 2 new crates:

  • sql-query-builder with sql specific query building logic
  • query-builder, currently a stub but will hold abstractions for query building

I've moved some models around to decouple query building and query structure from the connector logic.

@jacek-prisma jacek-prisma requested a review from a team as a code owner January 14, 2025 17:33
@jacek-prisma jacek-prisma requested review from jkomyno and removed request for a team January 14, 2025 17:33
Copy link

codspeed-hq bot commented Jan 14, 2025

CodSpeed Performance Report

Merging #5123 will degrade performances by 5.51%

Comparing chore/extract-sql-query-builder (06f8df6) with compiler (6b19a39)

Summary

❌ 1 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark compiler chore/extract-sql-query-builder Change
build (medium) 2.5 ms 2.6 ms -5.51%

@jacek-prisma jacek-prisma requested review from aqrln and removed request for jkomyno January 14, 2025 17:40
@aqrln aqrln added this to the 6.3.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants