Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: moving Bandada's vkey inside cloud function #332

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Fix: moving Bandada's vkey inside cloud function #332

merged 4 commits into from
Sep 24, 2024

Conversation

NicoSerranoP
Copy link
Member


name: moving Bandada's vkey inside cloud function
about: Open a PR for p0tion

Description

We are having some issues when trying to deploy the cloud functions in our production environment. According to a Firebase team comment in a Github issue, it might be related to having large data and actions in the global scope instead of inside the function (check comment here).

Fixes # (issue)

How Has This Been Tested?

I have not been able to test it due to the fact that the function deployment in prod environment happens when we merge the respective PRs.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I reviewed the code of conduct and contributors' guide

@NicoSerranoP NicoSerranoP merged commit 29c0eb1 into staging Sep 24, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants