Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify compile_solidity #49

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

mhh001
Copy link
Contributor

@mhh001 mhh001 commented Sep 14, 2023

#19 I added an error message with some simple code for no solidity compiler issue in compile_yul function.
But if you want another implementation, please let me know.

@mhh001 mhh001 changed the title modify compile_yul modify compile_solidity Sep 15, 2023
@han0110
Copy link
Collaborator

han0110 commented Sep 21, 2023

I think this works in most case, but it'd also be better to check the error is indeed due to solc not found. Actually I end up having the same function with error handling in another repo, would you mind updating the PR to use similar approach like https://github.com/han0110/halo2-solidity-verifier/blob/583c5e9f2e8b7b0a61d26416d3636d57903c1a30/src/evm.rs#L67-L83?

@mhh001
Copy link
Contributor Author

mhh001 commented Sep 22, 2023

Thank you for informing me about that! I updated the code refer to your existing code.

@han0110 han0110 merged commit 37b99a3 into privacy-scaling-explorations:main Sep 28, 2023
2 checks passed
zemse pushed a commit to zemse/snark-verifier that referenced this pull request Jan 18, 2024
…ndices` (privacy-scaling-explorations#49)

fix: `AggregationDependencyIntent` includes `accumulator_indices`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants