Make KzgDecidingKey fields public #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes privacy-scaling-explorations#55. This commit enables users to re-use more of snark-verifier code when implementing impl AccumulationDecider<_, MyLoader> for KzgAs<_, _> in order to define their own Loader and make it work with KZG10. The field `svk` was already exported through `impl AsRef<KzgSuccinctVerifyingKey<M::G1Affine>>`, but this commit additionally defines it as `pub` for consistency with `g2` and `s_g2` fields.
gnull
force-pushed
the
kzg-deciding-key-pub
branch
from
92a8837
to
b1aaa33
Compare
gnull
added a commit
to zeropoolnetwork/snark-verifier
that referenced
this pull request
Dec 7, 2023
Fixes privacy-scaling-explorations#55. This commit enables users to re-use more of snark-verifier code when implementing impl AccumulationDecider<_, MyLoader> for KzgAs<_, _> in order to define their own Loader and make it work with KZG10. The field `svk` was already exported through `impl AsRef<KzgSuccinctVerifyingKey<M::G1Affine>>`, but this commit additionally defines it as `pub` for consistency with `g2` and `s_g2` fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55.
This commit enables users to re-use more of snark-verifier code when implementing
in order to define their own Loader and make it work with KZG10.
The field
svkwas already exported throughimpl AsRef<KzgSuccinctVerifyingKey<M::G1Affine>>, but this commit additionally defines it aspubfor consistency withg2ands_g2fields.