Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworking the multipath implementation. The core of the update is to replace the flat structure
picoquic_path_tby a two level structure: onpicoquic_path_tper "unique path identifier", and a series ofpicoquic_tuple_tper address/port pairs tested on that path. This follows the discussion in issue #1854. The "RFC 9000 without multipath" handling of paths becomes a subset of the "multipath" mode, with just one path and potentially many tuples.With this change, we can now support the "preferred address" migration according to spec -- previous versions insisted on creating an extra path instead of migrating the path 0.
The new code is shorter, and (a bit) less complex. We could make it shorter still because know we have strict 1-1 relation between
picoquic_path_tstructures and number spaces, and also between these structures and lists of connection identifiers. But that should be the work of another PR.Close #1854.