Skip to content

Add additional secret volume mount#32

Merged
bryanbellsmith merged 8 commits into
mainfrom
extend-secret-volume-mount
Feb 9, 2026
Merged

Add additional secret volume mount#32
bryanbellsmith merged 8 commits into
mainfrom
extend-secret-volume-mount

Conversation

@bryanbellsmith

@bryanbellsmith bryanbellsmith commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

Purpose

This change allows the ability to add volumes / files from kubernetes secrets into the deployment. This is to support an upcoming feature where the container can optionally terminate TLS directly when supplied with the appropriate files and environment configuration.

What's changed

  • Moved all deployment-related values to a new deployment section in values.yaml
  • Minor fix for image pull secret name for external secrets
  • Added new additionalMounts section to the values file and deployment template
  • Bump version to prepare for release
  • Added scheme to the various deployment probes
  • Minor readme updates and typos

Testing

  • Tested locally with helm lint
  • Tested by Github CI
  • Tested in a local AWS cluster

Checklist

  • Update chart version if planning a release
  • Update README.md

@a-guiducci a-guiducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

kind: ExternalSecret
metadata:
name: {{ .Values.imagePullSecrets.name }}
name: {{ .Values.externalsecrets.dockercredential.name }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing external secrets made the wild decision not to use any casing format for their values?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, good point. We used to have the external secrets operator as a sub chart, and helm wouldn't support camel-case or dashes in subcharts without an alias, which I found a little flakey. I just left the section in the values the same name, but we can always switch it later to be consistent.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me, no need to go fixing what isn't broken

@bryanbellsmith
bryanbellsmith merged commit a77b614 into main Feb 9, 2026
1 check passed
@bryanbellsmith
bryanbellsmith deleted the extend-secret-volume-mount branch February 9, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants