Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snp_modifyBuild] add [local.chain] #492

Merged
merged 3 commits into from
Apr 18, 2024
Merged

[snp_modifyBuild] add [local.chain] #492

merged 3 commits into from
Apr 18, 2024

Conversation

Hugolyu
Copy link
Contributor

@Hugolyu Hugolyu commented Apr 15, 2024

Add parameter to use local files local.chain and changed the url download from https://hgdownload.soe.ucsc.edu/

Hi Florian,

I've added a new parameter to use the local chain files in snp_modifyBuild, and documented it in man/snp_modifyBuild.Rd.

The URL changes were cse to soe and ftp to https. I've tested it on my own computer and it seems to be working fine, but you need to test it multiple times to check for any potential bugs.

This is my first try pull request, and I appreciate the opportunity!

I hope it works well and this addition is useful.

Best regards,

Hugo

@privefl
Copy link
Owner

privefl commented Apr 17, 2024

I've made a few minor changes for my preference.
And some versioning.

It is annoying I cannot really write unit tests for this function, because liftOver is not available in the tests.

@privefl
Copy link
Owner

privefl commented Apr 18, 2024

Is it still working for you?

@Hugolyu
Copy link
Contributor Author

Hugolyu commented Apr 18, 2024

Yes! Still works well for me!
Many thanks.

@privefl privefl merged commit 7417a58 into privefl:master Apr 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants