Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get raw value #42 #278

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Get raw value #42 #278

wants to merge 2 commits into from

Conversation

lucasvst
Copy link

@lucasvst lucasvst commented Oct 23, 2018

This commit isolates the steps of formatting in separated functions. This way, when the code is setting the previousValue to element.dataset, it can get the rawValue and adds it to dataset too.

Looks like a big change, but I really just separated the code.

By the way, thanks for the directive. It's too useful.

@lucasvst
Copy link
Author

As I said, I just broke the main function in 3 functions and added one more test case. The cognitive complexity cannot be resolved without removing the switch/case strategy.

@probil
Copy link
Owner

probil commented Oct 23, 2018

Hey @lucasvst

Thanks for contribution! 👍

I like the idea. This library needs refactoring and I'm glad that someone makes it.

I will review changes soon.

@lucasvst
Copy link
Author

@probil thanks!

@probil probil self-assigned this Oct 23, 2018
@probil probil added this to the 1.4.0 milestone Oct 23, 2018
@probil
Copy link
Owner

probil commented Oct 23, 2018

I don't like switch too. If you have any ideas how we can improve it, let's do it (in the separate PR)

@probil probil mentioned this pull request Oct 23, 2018
@lucasvst
Copy link
Author

I don't like switch too. If you have any ideas how we can improve it, let's do it (in the separate PR)

I'll reserve some time to look it!

@YuraKostin
Copy link

Hello.
Thanks for the plugin.

This feature is very useful, so when will we can use it?

@probil probil modified the milestones: 1.4.0, next Jul 20, 2019
@tspratt
Copy link

tspratt commented Oct 1, 2019

It sure would be nice to have this.

@probil
Copy link
Owner

probil commented Oct 16, 2019

Thumb up if you like to have this PR merged.
This PR was made for v1 and update is required to make it work with v2

@edsonfeimberg
Copy link

1 year passed. Why wasn't this pull request accepted?

@Kocal
Copy link

Kocal commented Oct 23, 2020

Hi, what is the status of this PR?

Is it possible to rebase it and fix conflicts?

Thanks!

@sneko
Copy link

sneko commented Jan 30, 2021

Also interested :) any plan for this?

@Kocal
Copy link

Kocal commented Jan 30, 2021

As a workaround, I've replaced v-mask by vue-the-mast and it works really well 👍

@valsaven
Copy link

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants