Fix bug caused by variable name mix-up in gaussian_hmm.ipynb #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`params` and `true_params` were mixed up. This resulted in incorrect computation of the log joint probability under the true parameters and an incorrect "True" line in the plot of log prob versus num epochs.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paramsandtrue_paramswere mixed up. This resulted in incorrect computation of the log joint probability under the true parameters and an incorrect "True" line in the plot of log prob versus num epochs.Other results in the notebook have changed slightly. This may be because the notebook was last run with an earlier version of Dynamax that had unexpected nondeterminism (see e.g., #327). However, with the current version of Dynamax this notebook is now deterministic on my machine.