Skip unfreeze if no freeze comment found

Fixes #8
probot · Aug 29, 2017 · a29eaa1 · a29eaa1
1 parent f87c9ba
commit a29eaa1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/index.js b/index.js
@@ -49,7 +49,7 @@ module.exports = robot => {
         context.github.issues.getComments(githubHelper.parseCommentURL(issue.comments_url)).then(resp => {
           return freeze.getLastFreeze(resp.data);
         }).then(lastFreezeComment => {
-          if (freeze.unfreezable(lastFreezeComment)) {
+          if (lastFreezeComment && freeze.unfreezable(lastFreezeComment)) {
             freeze.unfreeze(issue, formatParser.propFromComment(lastFreezeComment));
           }
         });

diff --git a/lib/freeze.js b/lib/freeze.js
@@ -32,15 +32,9 @@ module.exports = class Freeze {
   }
 
   getLastFreeze(comments) {
-    let mainComment = {};
-    comments.reverse().some(comment => {
-      if (comment.user.login === this.config.probotUsername) {
-        mainComment = comment;
-        return true;
-      }
-      return false;
+    return comments.reverse().find(comment => {
+      return comment.user.login === this.config.probotUsername;
     });
-    return mainComment;
   }
 
   freeze(context, props) {