Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ts-ignore check #775

Closed
wants to merge 1 commit into from

Conversation

shivasankaran18
Copy link

@shivasankaran18 shivasankaran18 commented Apr 6, 2025

This PR adds an automated check to detect @ts-ignore comments in TypeScript files during PRs.

  • A Python script (detect_ts_ignore.py) that scans changed .ts/.tsx files for @ts-ignore comments.

  • If any @ts-ignore is found without a preceding comment like // Reason: ..., the check fails.

Closes #738

@ksen0
Copy link
Member

ksen0 commented Apr 8, 2025

Hi @shivasankaran18 , please note for future reference that PRs without an approved issue will be closed, as per the contributor guidelines:

You should not file a pull request (or start working on code changes) without a corresponding issue or before an issue has been approved for implementation; that is because the proposed fix may not be accepted, need a different approach entirely, or the actual problem is somewhere else. Any pull requests filed before the issue has been approved for fixing will be closed until approval is given to the issue.

@ksen0 ksen0 closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ts-ignore Check in CI Workflow
2 participants