Skip to content

Fix: p5 reference error in p5.MediaElement.loadPixels (ES module context) #8164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix: p5 reference error in p5.MediaElement.loadPixels (ES module context) #8164

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98160e5
Fix: use instance renderer in p5.MediaElement.loadPixels to support m…
Kakashi786 Oct 19, 2025
c4dcb8f
fix the lint/test issue
Kakashi786 Oct 22, 2025
de7fae0
Fix MediaElement pixel methods to use p5 instance parameter
Kakashi786 Oct 23, 2025
9511bd5
Remove unnecessary function wrapper
Homaid Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/dom/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4956,10 +4956,21 @@ class MediaElement extends p5.Element {
this._frameOnCanvas = this._pInst.frameCount;
}
}
loadPixels(...args) {
this._ensureCanvas();
loadPixels(...args) {
this._ensureCanvas();

// ✅ use the current p5 instance’s renderer instead of global p5
if (this._pInst && this._pInst._renderer) {
return this._pInst._renderer.loadPixels(...args);
}

// fallback for old global mode (just in case)
if (typeof p5 !== 'undefined' && p5.Renderer2D && p5.Renderer2D.prototype) {
return p5.Renderer2D.prototype.loadPixels.apply(this, args);
}

throw new Error('p5 instance or renderer not available in MediaElement.loadPixels()');
}
updatePixels(x, y, w, h) {
if (this.loadedmetadata) {
// wait for metadata
Expand Down
Loading