Skip to content

fix: prevent noSmooth crash on p5.Graphics (resolves #8264) #8286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rudrxxx wants to merge 2 commits into
base: dev-2.0
Choose a base branch
from
Open

fix: prevent noSmooth crash on p5.Graphics (resolves #8264) #8286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a9fa53
fix: prevent noSmooth crash on p5.Graphics (resolves #8264)
Nov 21, 2025
404436f
Merge branch 'dev-2.0' into fix-nosmooth-crash
Rudrxxx Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/shape/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,16 @@ function attributes(p5, fn){
* </code>
* </div>
*/
fn.noSmooth = function() {
if (!this._renderer.isP3D) {
if ('imageSmoothingEnabled' in this.drawingContext) {
this.drawingContext.imageSmoothingEnabled = false;
}
} else {
fn.noSmooth = function () {
if (this._renderer && typeof this._renderer.setSmoothing === 'function') {
this._renderer.setSmoothing(false);
} else if (
!this._renderer.isP3D &&
this.drawingContext &&
'imageSmoothingEnabled' in this.drawingContext
) {
this.drawingContext.imageSmoothingEnabled = false;
} else if (typeof this.setAttributes === 'function') {
this.setAttributes('antialias', false);
}
return this;
Expand Down
21 changes: 21 additions & 0 deletions test/manual-test-examples/noSmooth/canvas-2d.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
<title>Test noSmooth on main canvas 2D</title>
<script src="../../../lib/p5.js"></script>
<script>
function setup() {
createCanvas(100, 100);

try {
noSmooth();
console.log("✔ Main Canvas: noSmooth OK");
} catch (e) {
console.error("❌ Main Canvas: noSmooth ERROR", e);
}
}
</script>
</head>
<body></body>
</html>
22 changes: 22 additions & 0 deletions test/manual-test-examples/noSmooth/graphics-webgl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
<title>Test noSmooth on p5.Graphics WebGL</title>
<script src="../../../lib/p5.js"></script> <script>
function setup() {
createCanvas(100, 100, WEBGL);

const g = createGraphics(100, 100, WEBGL);

try {
g.noSmooth();
console.log("✔ WebGL p5.Graphics: noSmooth OK");
} catch (e) {
console.error("❌ WebGL p5.Graphics: noSmooth ERROR", e);
}
}
</script>
</head>
<body></body>
</html>
Loading