Skip to content

Fix set() to support p5.Graphics objects #8326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davepagurek merged 4 commits into from
Jan 11, 2026
+82 −4
Merged

Fix set() to support p5.Graphics objects #8326

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f26f436
Fix set() to support p5.Graphics objects
VANSH3104 Dec 10, 2025
5cba0fa
Add unit tests and improve set() handling for p5.Graphics
VANSH3104 Jan 7, 2026
0a44fbe
Add unit tests to suggested file and remove obsolete code
VANSH3104 Jan 8, 2026
7b68cbf
Merge branch 'dev-2.0' into setSupport
davepagurek Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/core/p5.Renderer2D.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,16 @@ class Renderer2D extends Renderer {
// round down to get integer numbers
x = Math.floor(x);
y = Math.floor(y);
if (imgOrCol instanceof Image) {
if (imgOrCol instanceof Graphics) {
this.drawingContext.save();
Copy link
Contributor

@davepagurek davepagurek Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, is the code in this branch the same as in the Image branch though? if so maybe we can simplify this by using an || condition and just having it be one branch?

Copy link
Contributor Author

@VANSH3104 VANSH3104 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are the same. I will update it.

this.drawingContext.setTransform(1, 0, 0, 1, 0, 0);
this.drawingContext.scale(
this._pixelDensity,
this._pixelDensity
);
this.drawingContext.drawImage(imgOrCol.canvas, x, y);
this.drawingContext.restore();
} else if (imgOrCol instanceof Image) {
this.drawingContext.save();
this.drawingContext.setTransform(1, 0, 0, 1, 0, 0);
this.drawingContext.scale(
Expand Down
Loading