Repository navigation
test(tcp): fail tcp_reactor_perf only on a recurring stall - #28
Merged
Merged
Conversation
The batch-consistency check failed whenever one batch took more than five times the median. A single host pause can do that at any time: on a loaded macOS host the same loop on OTP 29 failed the rule too, and unchanged Nera builds failed it in roughly one run in 250. Both checks now time batches in microseconds and fail only when the slowdown shows in at least two batches. The consistency check runs ten batches alternating between two connections, so a stall on every connection's first re-arm still fails it. The throughput check compares each of three sustained batches with the warmup.
A per-round probe on hosted macOS runners found single slow batches coming from bursts that slow many rounds and from whole-program pauses of 20 to 55 ms, with no round near the reactor's 100 ms poll timeout. The test header and the status paragraph now say so, and the status paragraph records the unexplained 126 to 137 ms rounds seen under full CPU load.
The hosted probe's 16 failures in 1,800 runs counted either old check. The batch rule failed about one run in 225 and the old throughput check about one run in 180; the status paragraph now says so.
mremond
force-pushed
the
fm/task-0b5601e6
branch
from
November 13, 2026 20:00
d649dd5 to
f3a44db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The macOS end-to-end check failed whenever one 200-round batch of the TCP re-arm loop ran five times slower than the median, and short bursts of host activity or brief whole-program pauses are enough to do that.
What changed
Before and after
Before: One slow batch failed the test: on hosted macOS runners the old checks failed about 1 run in 110, with no single round anywhere near the reactor's 100 ms fallback.
After: The new test passed every clean run on a loaded Mac and on this pull request's own build, and every injected recurring stall, first-round stall and slowdown still failed it.
This changes only how the project is checked; nothing a person sees changes.
Checked
Live validation: Demonstrated for this version. 6 of 6 scenarios driven live in the product.
How it was checked
Hosted checks passed on this version, including every end-to-end shard on macOS and Linux.
An independent review found nothing blocking; its wording corrections are included.
Risk
Risk: low in every dimension.
Full risk assessment
Not done
A real stall that happens only once per run does not fail the test; the hosted probe found no such stall without extra load.
A stall that hits only one of the three sustained batches no longer fails the throughput check.
The new rules' failure rate on hosted runners is not measured; estimates from the probe data suggest a few runs in a thousand.
The cause of the isolated 126 to 137 ms rounds under full processor load is not proven.
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.