Repository navigation
fix(runtime): include stacktraces in uncaught error exit reasons - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Uncaught native errors sent bare reasons to monitors and links, breaking BEAM-style matches on {Reason, Stacktrace}.
What changed
Before and after
Before: The two notification types, DOWN and EXIT, carried bare foo for error(foo), and the focused regression failed.
After: Both now carry {foo, Stacktrace}; 482 native end-to-end fixtures pass alongside repeated native and BEAM regressions.
This changes Erlang process notification payloads, not a screen; native message transcripts demonstrate the behavior.
Checked
Live validation: Demonstrated for this version. 3 of 3 scenarios driven live in the product.
How it was checked
cargo build --release --locked -p nera-runtime; cargo build --release --locked -p nera
cargo clippy --workspace --all-targets --locked -- -D warnings
cargo test --workspace --locked --no-fail-fast
python3 scripts/test-allocator-config.py
./target/release/nera test -j 1 --timeout 30
Native shutdown probe: ten configurations, thirty samples each, all median exit gaps below the existing five-millisecond budget.
Risk
Risk: low in every dimension.
Full risk assessment
Not done
Bundled proc_lib wrappers still catch errors and explicitly exit with bare reasons; they are outside this change.
Stack-frame ordering, trace-depth limits and uncaught-throw reasons are unchanged.
Local validation ran on macOS; Windows execution was not tested.
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.