Repository navigation
fix(runtime): report exited processes as no longer alive - #31
Merged
Merged
Conversation
mremond
force-pushed
the
fm/task-ce752de3
branch
from
November 14, 2026 08:35
2ce0297 to
c1993c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Native shutdown observers could briefly see stopped children as alive after their supervisor exited.
What changed
Before and after
Before: An untouched macOS build failed 71 of 1,600 contended supervisor fixture runs because stopped children still appeared alive.
After: The repaired macOS build completes ten consecutive fixture runs; its deterministic post-exit regression also passes ten consecutive runs.
This changes runtime process liveness, not a graphical view; native execution transcripts and the deterministic regression demonstrate the result.
Checked
Live validation: Demonstrated for this version. 1 of 1 scenarios driven live in the product.
How it was checked
Built runtime before compiler with cargo build --release --locked -p nera-runtime and cargo build --release --locked -p nera, then built the workspace.
Ran cargo clippy --workspace --all-targets --locked -- -D warnings and cargo test --workspace --locked --no-fail-fast.
Ran python3 scripts/test-allocator-config.py, nera test -j 1 --timeout 30, python3 scripts/ci/test_changes.py and both scripts/test-cross.sh targets.
Ran both the liveness regression and the overlapping linked-exit accounting regression ten times each without retries or sleeps. Compiled and ran the unchanged native and OTP 29 supervisor_shutdown fixtures ten times each.
Ran python3 scripts/test-native-shutdown.py with 30 samples for each of five programs at both default and single-scheduler settings. The retained linked-exit native probe completed ten runs at each scheduler setting with exact output, empty stderr and natural blocked-only termination.
Resolved only changelog context when bringing the branch up to date. Every approved added and removed line remains identical in all four changed paths; the newer lifecycle code is retained unchanged and covered by the combined gate.
Untouched Linux aarch64 reproduced 83 liveness assertion failures in 600 contended executions. The interrupted fixed Linux repetition produced no result; hosted Linux checks provide repaired-version coverage.
The historical hosted Linux x86_64 failure is consistent with this defect, but its five-line diagnostic limit prevents unique attribution. No assertion, timeout or expectation was weakened.
Risk
Risk: low in every dimension.
Full risk assessment
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.