Repository navigation
fix(fmt): preserve grouping of negated negative literals - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Formatting negated negative literals must produce valid Erlang and remain unchanged on a second pass.
What changed
Before and after
Before: Both representative expressions formatted into invalid list-subtraction tokens: --0 and --99999999999999999999.
After: Both expressions retain valid grouping; thirteen CLI examples compile with identical values on Erlang/OTP.
This changes formatted Erlang source, not an on-screen view; CLI output and OTP compilation demonstrate the result.
Checked
Live validation: Demonstrated for this version. 1 of 1 scenarios driven live in the product.
How it was checked
cargo test --locked -p nera-fmt --test negative_literals; ten consecutive runs without retries
cargo build --release --locked -p nera-runtime; cargo build --release --locked
cargo clippy --workspace --all-targets --locked -- -D warnings
cargo test --workspace --locked --no-fail-fast: 2,187 passed, one ignored
./target/release/nera test -j 1 --timeout 30: 496 passed, two external-module skips
python3 scripts/test-allocator-config.py; python3 scripts/test-stacktrace-order.py
Real formatter CLI, repeated formatting, format check, and original/formatted OTP compilation and encoded-value comparison
Risk
Risk: low in every dimension.
Full risk assessment
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.