Repository navigation
fix(syntax): match BEAM errors for invalid bitstring units - #48
Merged
Merged
Conversation
mremond
force-pushed
the
fm/task-90af6d72
branch
from
November 15, 2026 09:35
f6bec8a to
ed2927d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Bitstring segment units should fail with BEAM-compatible errors, including zero and values beyond the valid range.
What changed
Before and after
Before: Only 24 of 64 compiler comparisons matched BEAM's diagnostic text, although all rejection outcomes already matched.
After: All 64 comparisons now match BEAM's outcomes and diagnostic text, with valid-unit native behavior unchanged.
This changes compiler diagnostics, not a graphical view; actual compiler and native-program transcripts demonstrate the result.
Checked
Live validation: Demonstrated for this version. 3 of 3 scenarios driven live in the product.
How it was checked
cargo build --release --locked -j 4
cargo clippy --workspace --all-targets --locked -j 4 -- -D warnings
cargo test --workspace --locked --no-fail-fast -j 4
python3 scripts/test-allocator-config.py
./target/release/nera test -j 1 --timeout 30
python3 scripts/test-stacktrace-order.py
python3 -m unittest discover -s scripts/ci -p 'test_*.py'
Ten consecutive runs of the parser test module, semantic warnings tests and three new compile-error fixtures.
Independent code and live-proof review passed.
Risk
Risk: low in every dimension.
Full risk assessment
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.