Repository navigation
fix(runtime): compare closures by code and captured values - #49
Merged
Merged
Conversation
mremond
force-pushed
the
fm/task-7cce240c
branch
from
November 15, 2026 09:56
6e8b75b to
7b3a6a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closures from the same fun expression with equal captured values should compare equal and work as interchangeable keys, as on BEAM.
What changed
Before and after
Before: Two separately created equal closures compared unequal under both operators and missed lookups in all three key stores.
After: Both comparisons now return true, and all three key stores find the equivalent closure, matching BEAM.
This changes Erlang runtime behavior, not a visual interface; native and BEAM execution transcripts demonstrate the result.
Checked
Live validation: Demonstrated for this version. 2 of 2 scenarios driven live in the product.
How it was checked
cargo build --release --locked -p nera-runtime
cargo build --release --locked
cargo clippy --workspace --all-targets --locked -- -D warnings
cargo test --workspace --locked --no-fail-fast
python3 scripts/test-allocator-config.py
./target/release/nera test -j 1 --timeout 30
python3 scripts/test-stacktrace-order.py
Risk
Risk above low: Blast radius, medium — Shared term comparison and compound ETS key encoding change.
Full risk assessment
Not done
Windows execution and BEAM-compatible fun hashes are not established by this change.
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.