Repository navigation
fix(ir): preserve leading comprehension filters - #51
Merged
Merged
Conversation
mremond
force-pushed
the
fm/task-d20dba4e
branch
2 times, most recently
from
November 15, 2026 10:34
271022a to
8ecffe0
Compare
mremond
force-pushed
the
fm/task-d20dba4e
branch
from
November 15, 2026 10:57
8ecffe0 to
17f53e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
List and binary comprehensions must honor filters before their first generator and support filter-only forms, matching BEAM.
What changed
Before and after
Before: Both false-prefix forms produced two values, and filter-only comprehensions failed to compile.
After: Both false-prefix forms return empty; filter-only forms produce one body, matching BEAM.
This changes compiled Erlang results, not a graphical view.
Checked
Live validation: Demonstrated for this version. 3 of 3 scenarios driven live in the product.
How it was checked
Runtime-first release build and strict workspace lint passed.
The complete Rust workspace passed 2,193 tests; one existing release-only measurement remains ignored.
Preserved the accepted complete native run of 501 passes and two existing external-project skips; all 23 affected journeys passed after the self-exit update.
The fresh stacktrace check passed; earlier allocator and complete verifier/BEAM repetition proof remains preserved for unchanged scope.
The shared fixture passed ten fresh native runs; all twelve disposable self-exit/comprehension cases passed on native and BEAM.
Risk
Risk above low: Novelty, medium — Adds prefix control flow using existing lowering and exception primitives.
Full risk assessment
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.