Repository navigation
fix(ir): compile unsupported float widths with OTP warnings - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Erlang modules should compile unsupported literal float widths while retaining OTP's warnings and runtime behavior.
What changed
Before and after
Before: The new regression could not compile because Nera classified unsupported float widths as errors.
After: The same regression compiles with warnings and passes on native Nera and OTP.
This changes compiler diagnostics and retained runtime behavior, not a graphical view; command output and editor diagnostic responses provide evidence.
Checked
Live validation: Demonstrated for this version. 3 of 3 scenarios driven live in the product.
How it was checked
cargo build --release --locked -j 6
cargo clippy --workspace --all-targets --locked -j 6 -- -D warnings
cargo test --workspace --locked --no-fail-fast -j 6
python3 scripts/test-allocator-config.py
./target/release/nera test -j 1 --timeout 30
python3 scripts/test-stacktrace-order.py
cargo test --locked -p nera-ir -j 6 warnings::tests:: -- --test-threads=1, repeated ten times
./target/release/nera test binary_float_unsupported_width -j 1 --timeout 30, repeated ten times
Compiled and ran the same regression on OTP 29.1.2.
Compared native and OTP demonstration output byte for byte and verified suppression through the editor diagnostic server.
Risk
Risk: low in every dimension.
Full risk assessment
Not done
Two existing external-module native tests remain skipped.
Per-function warning suppression is verified in editor diagnostics; the existing command-line path does not apply those pragmas.
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.