Repository navigation
fix(ir): preserve error stacktraces in catch expressions - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Error results from catch expressions should retain the diagnostic frames already available through try/catch.
What changed
Before and after
Before: Error catch results contained 0 stacktrace frames, even when try/catch captured the failing function and its callers.
After: Ordinary caught errors retain 3 shared frames and their metadata, matching try/catch; explicitly empty supplied traces still contain 0 frames.
This changes returned Erlang terms, not a graphical view; compiled-program transcripts demonstrate the result.
Checked
Live validation: Demonstrated for this version. 3 of 3 scenarios driven live in the product.
How it was checked
cargo build --release --locked -p nera-runtime; cargo build --release --locked -p nera
cargo clippy --workspace --all-targets --locked -- -D warnings
cargo test --workspace --locked --no-fail-fast
./target/release/nera test -j 1 --timeout 30
python3 scripts/test-allocator-config.py; python3 scripts/test-stacktrace-order.py
bash scripts/test-cross.sh ./target/release/nera x86_64-apple-darwin; bash scripts/test-cross.sh ./target/release/nera aarch64-unknown-linux-gnu
The new Erlang fixture ran ten times per native scheduler mode and on BEAM, with both its completion marker and an asserted ok return.
An intermediate suspension assertion failed during development; the corrected fixture and final complete suite pass.
Risk
Risk: low in every dimension.
Full risk assessment
Not done
Native try/catch's existing loss of caller frames across suspension is outside this fix; catch retains the same available trace.
Two native tests require external example modules and remain skipped.
Cross-target probes inspect object formats; Windows execution was not validated.
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.