Repository navigation
fix(ir): reject same-head inputs at every pattern site - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Match erlc by rejecting map keys and binary sizes supplied only by the pattern being matched.
What changed
Before and after
Before: Nera accepted ten invalid programs that erlc rejects.
After: Nera rejects all ten programs while valid prior inputs and sequential binary sizes still execute correctly.
This compiler change has no graphical view; retained command outputs demonstrate the diagnostics and native completion checks.
Checked
Live validation: Demonstrated for this version. 3 of 3 scenarios driven live in the product.
How it was checked
cargo build --release --locked -j 4
cargo clippy --workspace --all-targets --locked -j 4 -- -D warnings
cargo test --workspace --locked --no-fail-fast -j 4 -- --test-threads=4
./target/release/nera test -j 1 --timeout 30
python3 scripts/test-allocator-config.py; python3 scripts/test-stacktrace-order.py
Complete Cowlib and Thoas integration harnesses, differential corpora, OTP probes and native assertion bodies ran on macOS arm64.
Cowlib's upstream build required a disposable path without spaces; its initial failure occurred before Nera and the unchanged pinned source passed under that path.
Risk
Risk: low in every dimension.
Full risk assessment
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.