Fix PageImage::maxSize() not generating the expected file, resulting in a Warning #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you call
$img->maxSize(0, 300)
or$img->maxSize(0, 0)
on an image that is already within those dimensions, it will not create a variation but return aPageImage
as if it had, resulting in a PHP warning and a 404 for the image:In fact, this problem still happens for
$img->size(0, 0)
, so perhaps a better fix would be somewhere deeper down the callstack. I’m using the defaultImageSizerEngineGD
here.This is kind of hackish anyway, passing down the original image dimension instead of 0. Maybe it even breaks something somewhere, but it seems to scratch my personal itch okay at this time. Is there a test suite to make sure PRs don’t break anything?
Thanks!