Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rev dependencies, ESM, and fix unit test harness #16

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

joshperry
Copy link
Contributor

updates all deps to latest
adopts native ESM (since node 14)
replace proxyquire with esmock
updates code for newest got lib
update eslint config to es2020+ESM and add to deps+scripts (npm run lint)
unit tests pass on node 14 and 18.

Copy link
Contributor

@dima11051994 dima11051994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this maintenance update! But since some of the changes are pretty major, specifically socket.io client update, I would suggest to bump the package version to 1.0.0. New socket client is incompatible with an old socket.io server 1.x and 2.x that is still running on many cloud nodes.

@joshperry
Copy link
Contributor Author

No problem.

My primary concern was getting unit tests working to ensure the expected operation of the library with #13 and #15 pending. I made an assumption that you were either updating the cloud nodes or were going to start terminating these with a newer server version in the cloud for multisite since #13 is already updating socket-io to v4 with only a semver patch bump, with #15 also being based on it.

I'm fine making this a major bump, it just didn't seem to align with what was planned in these PRs.

Also, is there a target minimum node version that you guys need to support on the client side? I'd like to add that constraint to package.json.

@joshperry
Copy link
Contributor Author

The reasoning for bumping the other deps was primarily around security concerns.
image

@dima11051994 dima11051994 merged commit 12d77ed into prodatakey:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants