Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The original implementation would call the webhooks for both success and failure. Without checking the contents of the JSON body a health check service would be unable to distinguish between those two.
Typical healthcheck provider would expect different endpoints for success, start, progress and failure (if the latter is are supported at all).
Here's one example: https://healthchecks.io/docs/signaling_failures/
What
This extends the webhook support to be friendlier with dead-man-switch health check services.
It adds 3 more optional env vars and will call the specified endpoints as needed.
Backwards compatibility
The original
WEBHOOK_URL
and its behaviour is untouched, so this change is 100% backwards compatible.