Allow approval of pull request target workflows #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more environments require approval before deploying workflow runs. Maintainers, please inspect changes carefully for improper handling of secrets or other sensitive information. To approve pending deployments, submit an approved review, or a commented review with |
1 similar comment
|
One or more environments require approval before deploying workflow runs. Maintainers, please inspect changes carefully for improper handling of secrets or other sensitive information. To approve pending deployments, submit an approved review, or a commented review with |
The previous pending workflow query was based on the reviewed commit SHA but this would not return any pull_request_target events. This change updates the filter to find all pending workflows based on the branch, then reduces the list further by approved commits or event type. The events must already be in a pending state before the approval is received, this is unchanged. Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
changed the title
Exclude workflows that were created within one minute of the review being submitted. This is to prevent time-of-check to time-of-use (TOCTOU) attacks. Change-type: minor Signed-off-by: Kyle Harding <[email protected]>
klutchell
changed the title
klutchell
changed the title
cywang117
reviewed
Feb 27, 2025
cywang117
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous pending workflow query was based on the reviewed
commit SHA but this would not return any pull_request_target events since the commit would be out-of-tree.
This change updates the filter to find all pending workflows based
on the branch, then reduces the list further by approved commits
or event type.
Also exclude workflows that were created within one minute of the review being submitted.
This is to prevent time-of-check to time-of-use (TOCTOU) attacks.