-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torchat py enhancements #47
Open
bit-fag
wants to merge
83
commits into
prof7bit:torchat_py
Choose a base branch
from
bit-fag:torchat_py
base: torchat_py
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bit-fag
commented
Nov 12, 2013
- second instance
- plugins (conference, ping, rock paper scissors, password, ...)
- bugfix
TOR_CONFIG tor_pid tor_proc tor_timer startPortableTor() stopPortableTor() startPortableTorTimer() onPortableTorTimer()
* tor_portable.socks_port * client.port
fix attribute error in subclass Check
additional config item is to prefer nicks over torchat ids
move isValidAddress to global tc_client's namespace
allow UTF-8 in user agent
plugins must not be loaded each time torchat module is imported
imp reinitializes module even if it is already loaded
*settings item for replacement text *translations
plugin description are not translated if translation is not imported
If somebody removed his avatar, this was reflected in GUI only after GUI restart
* roles * mute/kick/etc * topic, description, avatar
calling GUI directly from network thread is dangerous
addPluginSettings is defined by plugin This was changed to avoid double calls to .fit() which is buggy on win32
for example, banned members
If user chanhes his profile_name, this event is sent to other users. Previous behaviour was to do nothing, if this user had name already set (local alias OR remote profile_name). Current variant will not update user name if name change happened while user was offline.
and change format from simple text to JSON. * new lines in profile_name could break simple text format * store both name (set by local user) and profile_name (set by remote user)
Do this in method buddy.getShortDisplayName Method buddy.getDisplayName shown address and (buddy.getShortDisplayName) if differs.
* too long words in profile_name could cause crases in tooltip * new lines in profile_name could confuse user
Client will use tor_portable and tor (eg, system-wide), depends on value of client.tor_config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.