Fix for window not always closing #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug where, for some people, self.Close in the onCancel function will not work. This will effectively make it so the window cannot be closed at all. Not with the cancel button, the ok button, or the x button on the window. However, like in the dlg_settings file, it uses evt.Skip() to close their windows and it works perfectly. Appending it after the self.Close() function seems to fix this bug. The onCancel function ties into all close functions so when someone hits ok or the x button, not just the cancel button, onCancel is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug where, for some people, self.Close in the onCancel function will not work. This will effectively make it so the window cannot be closed at all. Not with the cancel button, the ok button, or the x button on the window. However, like in the dlg_settings file, it uses evt.Skip() to close their windows and it works perfectly. Appending it after the self.Close() function seems to fix this bug. The onCancel function ties into all close functions so when someone hits ok or the x button, not just the cancel button, onCancel is called.