Mobile support with failback spike #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: app/controllers/people_controller.rb app/controllers/welcome_controller.rb config/initializers/mime_types.rb
|
Thank you for this pull request. Out of curiosity, did you explore the media="mobile.css" solution to render a different page for mobile? I'll go watch the railscast next, as he probably talks about why your solution is better. |
| last_name "Liu" | ||
| human_name "David Liu" | ||
| email "david.liu@sv.cmu.edu" | ||
| webiso_account "david.liu@andrew.cmu.edu" | ||
| end |
There was a problem hiding this comment.
Note to self: Ignore this commit
There was a problem hiding this comment.
You're right. This should not have been checked in. Our Bad.
|
@professor: According to our research it seems that creating a mime type for mobile provides a more universal platform for extending mobile support to other modules by simply creating a new *.mobile.erb version of the view and changing the content. We felt that this approach is less intrusive as well. I would love to hear your comments about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MfSE Team Defect
Story Definition: As a user, when I access the site on a mobile device, if I go to the home page, I see just the links on the left navigation. If I go to people search, then I just see the main content window. This should work on iphone and android.
Implementation:
Reference: http://railscasts.com/episodes/199-mobile-devices