Skip to content

fix(hetzner): reject malformed API prices - #927

Merged
ralyodio merged 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/hetzner-strict-price
Aug 3, 2026
Merged

fix(hetzner): reject malformed API prices#927
ralyodio merged 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/hetzner-strict-price

Conversation

@aiirvizionz

Copy link
Copy Markdown
Contributor

Summary

  • reject malformed Hetzner API price strings instead of partially parsing them
  • use the same strict decimal parsing for quotes, server selection, and volume rates
  • add focused coverage for valid, malformed, and non-decimal values

Validation

  • .\\node_modules\\.bin\\vitest.cmd run packages/cloud/hetzner/src/index.test.ts packages/cloud/hetzner/src/price.test.ts
  • .\\node_modules\\.bin\\tsc.cmd -p packages/cloud/hetzner/tsconfig.json --noEmit
  • git diff --check

Copilot AI review requested due to automatic review settings August 1, 2026 21:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

3 similar comments
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@ralyodio
ralyodio merged commit 329fcbf into profullstack:master Aug 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants