Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/bots/signal/src/index.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { describe, expect, it } from 'vitest';
import { contractTestBot } from '@profullstack/sh1pt-core/testing';
import bot, { loadConfig } from './index.js';
import bot, { loadConfig, toBotEvent } from './index.js';

contractTestBot(bot, { sampleConfig: {}, sampleChannel: '+15551234567' });

Expand Down Expand Up @@ -50,3 +50,17 @@ describe('loadConfig', () => {
expect(config.maxConcurrentSessions).toBe(5);
});
});

describe('toBotEvent', () => {
it('falls back when Signal provides an out-of-range timestamp', () => {
expect(toBotEvent({
source: 'user-1',
sourceName: 'User',
text: 'hello',
timestamp: Number.POSITIVE_INFINITY,
groupId: undefined,
attachments: [],
raw: {},
}).timestamp).toBe('1970-01-01T00:00:00.000Z');
});
});
5 changes: 3 additions & 2 deletions packages/bots/signal/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ function parsePositiveSafeIntegerEnv(value: string | undefined, fallback: number
return Number.isSafeInteger(parsed) && parsed > 0 ? parsed : fallback;
}

function toBotEvent(msg: IncomingMessage): BotEvent {
export function toBotEvent(msg: IncomingMessage): BotEvent {
const date = new Date(msg.timestamp);
return {
type: "message",
channel: msg.groupId ?? msg.source,
Expand All @@ -128,7 +129,7 @@ function toBotEvent(msg: IncomingMessage): BotEvent {
},
text: msg.text,
attachments: msg.attachments.map((a) => ({ url: a.url, filename: a.filename })),
timestamp: new Date(msg.timestamp).toISOString(),
timestamp: Number.isNaN(date.getTime()) ? new Date(0).toISOString() : date.toISOString(),
};
}

Expand Down
Loading