-
Notifications
You must be signed in to change notification settings - Fork 0
feat(whisper-api): with endpoint #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @luoling8192, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the Hugging Face API client initialization within the whisper-api
application. It introduces a dedicated module to centralize the API client creation, enabling configuration of the Hugging Face endpoint and cache directory through environment variables. This change improves the application's configurability and maintainability by standardizing how external Hugging Face resources are accessed.
Highlights
- Centralized Hugging Face API Configuration: Introduced a new module
huggingface.rs
to encapsulate the logic for creating and configuring the Hugging Face API client. This centralizes the setup forhf_hub::api::sync::Api
instances. - Environment Variable Support for HF Endpoint and Cache: The new
create_hf_api
function allows specifying a custom Hugging Face API endpoint via theHF_MIRROR
environment variable and a custom cache directory via theHF_HOME
environment variable, enhancing deployment flexibility. - Integration with Existing Components: Updated the
VADProcessor
andWhisperProcessor
initialization logic to utilize the newhuggingface::create_hf_api()
function, ensuring all model loading benefits from the centralized and configurable API client.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a factory function, create_hf_api
, to centralize the creation of the Hugging Face API client, allowing for configuration via environment variables. The review includes suggestions to make the handling of these environment variables more robust by checking for empty strings, which will prevent potential runtime errors.
threshold: f32, | ||
) -> Result<Self> { | ||
let api = hf_hub::api::sync::Api::new()?; | ||
let api = huggingface::create_hf_api()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, support all HF API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HF SDK only supports endpoint
, cache_dir
, and token
.
The retries
and user-agent
, which are unnecessary for the user to set by user.
Follow Gemini. |
No description provided.