Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Update job ttl to make it configurable #695

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

emuthiah
Copy link

@emuthiah emuthiah commented May 10, 2024

What this PR does / why we need it:
This PR adds the ability to set non-zero value for .spec.ttlSecondsAfterFinished field of webhook Jobs. It is needed because some CD tools (eg. ArgoCD) are not able to get the status of the completed Job before it is cleaned up and hangs at syncing status. By setting ttlSecondsAfterFinished value to non-zero (eg. 10 seconds), it gives ArgoCD enough time to get the status of the job and complete sync operation.
This change does not break or change existing functionality. It add the ability to change ttlSecondsAfterFinished if required.
Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@diconico07
Copy link
Contributor

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label May 27, 2024
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/patch Patch version change is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants