Skip to content

Commit

Permalink
Fix command check (merge conflict?)
Browse files Browse the repository at this point in the history
  • Loading branch information
cecille committed Sep 17, 2024
1 parent fdf55ce commit 05f4297
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/python_testing/TC_DeviceConformance.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ def record_warning(location, problem):
if attribute_id not in self.xml_clusters[cluster_id].attributes.keys():
# TODO: Consolidate the range checks with IDM-10.1 once that lands
if attribute_id <= 0x4FFF:
# manufacturer attribute
record_error(location=location, problem='Standard attribute found on device, but not in spec')
continue
xml_attribute = self.xml_clusters[cluster_id].attributes[attribute_id]
Expand All @@ -193,9 +192,7 @@ def check_spec_conformance_for_commands(command_type: CommandType):
if command_id not in xml_commands_dict:
# TODO: Consolidate range checks with IDM-10.1 once that lands
if command_id <= 0xFF:
# manufacturer command
continue
record_error(location=location, problem='Standard command found on device, but not in spec')
record_error(location=location, problem='Standard command found on device, but not in spec')
continue
xml_command = xml_commands_dict[command_id]
conformance_decision_with_choice = xml_command.conformance(feature_map, attribute_list, all_command_list)
Expand Down

0 comments on commit 05f4297

Please sign in to comment.