Skip to content

Commit

Permalink
Restyle
Browse files Browse the repository at this point in the history
  • Loading branch information
andreilitvin committed Sep 17, 2024
1 parent 0b794c4 commit 3229704
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -331,15 +331,15 @@ DataModel::ActionReturnStatus CodegenDataModelProvider::WriteAttribute(const Dat
if (checkAcl && request.previousSuccessPath.has_value())
{
// NOTE: explicit cast/check only for attribute path and nothing else.
//
//
// In particular `request.path` is a DATA path (contains a list index)
// and we do not want request.previousSuccessPath to be auto-cast to a
// and we do not want request.previousSuccessPath to be auto-cast to a
// data path with a empty list and fail the compare.
//
// This could be `request.previousSuccessPath != request.path` (where order
// is important) however that would seem more brittle (relying that a != b
// is important) however that would seem more brittle (relying that a != b
// behaves differently than b != a due to casts). Overall Data paths are not
// the same as attribute paths.
// the same as attribute paths.
//
// Also note that Concrete path have a mExpanded that is not used in compares.
const ConcreteAttributePath & attributePathA = request.path;
Expand Down

0 comments on commit 3229704

Please sign in to comment.