Skip to content

Commit

Permalink
Add Matter.framwework logging for invoke work items that exceed timed…
Browse files Browse the repository at this point in the history
… invoke timeout. (#37179)

We should log what happened to the work item, not just silently complete it.
  • Loading branch information
bzbarsky-apple authored Jan 24, 2025
1 parent 1ae6ad6 commit 8ec0731
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/darwin/Framework/CHIP/MTRDevice_Concrete.mm
Original file line number Diff line number Diff line change
Expand Up @@ -3265,6 +3265,7 @@ - (void)_invokeCommandWithEndpointID:(NSNumber *)endpointID
if ([now compare:cutoffTime] == NSOrderedDescending) {
// Our timed invoke timeout has expired already. Command
// was queued for too long. Do not send it out.
MTR_LOG("Invoke work item [%llu] timed out its timed invoke timeout before being dispatched", workItemID);
workDone(nil, [MTRError errorForIMStatusCode:Status::Timeout]);
return;
}
Expand Down

0 comments on commit 8ec0731

Please sign in to comment.