Address further review comments for Darwin layer

project-chip · Jan 19, 2025 · a2e0df1 · a2e0df1
1 parent f8f68a6
commit a2e0df1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/darwin/Framework/CHIP/MTRDeviceType.mm b/src/darwin/Framework/CHIP/MTRDeviceType.mm
@@ -45,7 +45,7 @@ - (NSNumber *)id
 
 - (NSString *)name
 {
-    return const_cast<NSString *>(_meta->name);
+    return _meta->name;
 }
 
 - (BOOL)isUtility

diff --git a/src/darwin/Framework/CHIP/MTREndpointInfo.mm b/src/darwin/Framework/CHIP/MTREndpointInfo.mm
@@ -164,6 +164,7 @@ + (BOOL)populateChildrenForEndpoints:(NSDictionary<NSNumber *, MTREndpointInfo *
         NSArray<MTRDescriptorClusterDeviceTypeStruct *> * deviceTypeList = MTRDecodeAttributeValue(path, *cache, &err);
         if (!deviceTypeList) {
             MTR_LOG_ERROR("Ignoring invalid DeviceTypeList for endpoint %u: %" CHIP_ERROR_FORMAT, path.mEndpointId, err.Format());
+            // proceed with deviceTypeList == nil, equivalent to an empty list
         }
 
         NSMutableArray * deviceTypes = [[NSMutableArray alloc] initWithCapacity:deviceTypeList.count];