Skip to content

Commit

Permalink
Log cluster/command names in MTRBaseDevice invoke. (#37090)
Browse files Browse the repository at this point in the history
We were doing this in MTRDevice already, but not in MTRBaseDevice.
  • Loading branch information
bzbarsky-apple authored Jan 16, 2025
1 parent 184127e commit ac7f062
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/darwin/Framework/CHIP/MTRBaseDevice.mm
Original file line number Diff line number Diff line change
Expand Up @@ -1445,7 +1445,10 @@ - (void)_invokeCommandWithEndpointID:(NSNumber *)endpointID
}

if (logCall) {
MTR_LOG("%@ invoke %@ 0x%llx 0x%llx: %@", self, endpointID, clusterID.unsignedLongLongValue, commandID.unsignedLongLongValue, commandFields);
MTR_LOG("%@ invoke %@ 0x%llx (%@) 0x%llx (%@): %@", self, endpointID,
clusterID.unsignedLongLongValue, MTRClusterNameForID(static_cast<MTRClusterIDType>(clusterID.unsignedLongLongValue)),
commandID.unsignedLongLongValue, MTRRequestCommandNameForID(static_cast<MTRClusterIDType>(clusterID.unsignedLongLongValue), static_cast<MTRCommandIDType>(commandID.unsignedLongLongValue)),
commandFields);
}

auto * bridge = new MTRDataValueDictionaryCallbackBridge(queue, completion,
Expand Down

0 comments on commit ac7f062

Please sign in to comment.