Re-enabling unit tests for EFR32 which had been disabled due to flash limitations #35456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35456: Size comparison from e96ddd9 to 1f0c2b0 Full report (74 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Oct 3, 2024
andy31415
reviewed
Oct 3, 2024
andy31415
approved these changes
Oct 3, 2024
jmartinez-silabs
approved these changes
Oct 7, 2024
…nto feature/matter-enable-efr32
FergusHuang
pushed a commit
to FergusHuang/connectedhomeip
that referenced
this pull request
Oct 20, 2024
… limitations (project-chip#35456) * Removed as many efr32 checks as possible without having to make code modifications * Updated comments to show error message * Restyled by clang-format * Comment updates * ci testing 1 * Re-added suites * . * . * comment icd tests * removed 5 tests from line 112 * re-enable app/tests in the main tests group * reverted to original (with inconsequential mods) * (addendum) Now actually reverted back to original state (with inconsequential mods) * moved 4 dirs up into the main tests lists * enabled 3-test-set for efr32 * moved tracing tests out of the if * enable platform tests for efr32 * enabled controller and datamodel tests but not the stuff in controller * enabled all tests in controller * add transport tests back in * enabled data_model Test[Commands,Read,Write] * commands is in, read/write is out * added TestRead * Added TestWrite, removed TestRead * src/app/tests remains disabled * changed c-style cast to static_cast * Added TestTLVVectorWriter.cpp back in * comment update * restyle fixes * restyle fixes --------- Co-authored-by: Restyled.io <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
… limitations (project-chip#35456) * Removed as many efr32 checks as possible without having to make code modifications * Updated comments to show error message * Restyled by clang-format * Comment updates * ci testing 1 * Re-added suites * . * . * comment icd tests * removed 5 tests from line 112 * re-enable app/tests in the main tests group * reverted to original (with inconsequential mods) * (addendum) Now actually reverted back to original state (with inconsequential mods) * moved 4 dirs up into the main tests lists * enabled 3-test-set for efr32 * moved tracing tests out of the if * enable platform tests for efr32 * enabled controller and datamodel tests but not the stuff in controller * enabled all tests in controller * add transport tests back in * enabled data_model Test[Commands,Read,Write] * commands is in, read/write is out * added TestRead * Added TestWrite, removed TestRead * src/app/tests remains disabled * changed c-style cast to static_cast * Added TestTLVVectorWriter.cpp back in * comment update * restyle fixes * restyle fixes --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables unit tests for EFR32 which had been disabled due to flash limitations. This is made possible by recent changes that split the unit tests up into separate binaries for each test source, rather than making a single monolithic binary.
Enabled the following test suites:
The following test source files remain disabled because controller related API is not implemented for EFR32:
The following test suites remain disabled, due to
_opennot being implemented: