Spec parsing: Add global commands for thermostat #35607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 3 of 3 files. Overall, the semantic diff is 10% smaller than the GitHub diff.
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #35607: Size comparison from 010ad94 to 3634532 Full report (20 builds for nxp, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248 and
hicklin
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #35607: Size comparison from 010ad94 to 3fdfc6c Increases above 0.2%:
Full report (26 builds for efr32, esp32, nxp, telink)
|
hasty
approved these changes
Sep 18, 2024
cjandhyala
approved these changes
Sep 19, 2024
woody-apple
approved these changes
Sep 19, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Sep 20, 2024
* Spec parsing: Add global commands for thermostat * use in-progress for clusters too * Fix command check (merge conflict?) * Restyled by isort * Fix test that checks the default cluster dir --------- Co-authored-by: Restyled.io <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Spec parsing: Add global commands for thermostat * use in-progress for clusters too * Fix command check (merge conflict?) * Restyled by isort * Fix test that checks the default cluster dir --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atomic write does not appear in the DM scrape as a part of the thermostat cluster, so it needs to be manually added in order to allow the thermostat clusters with presets to pass IDM tests.