[Test] Creating CADMIN 1.19 python3 test module #35611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test module created following steps in PR: CHIP-Specifications/chip-test-plans#4669
|
Review changes with Changed Files
|
j-ororke
changed the title
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #35611: Size comparison from 010ad94 to 76142a6 Full report (26 builds for efr32, esp32, nxp, telink)
|
- Resolving linting issues
- Removed yaml test as we have created python test module in its place
|
PR #35611: Size comparison from 010ad94 to 4c04d29 Full report (3 builds for nxp)
|
- Removed debugging print statements as no longer needed in test code
|
PR #35611: Size comparison from 010ad94 to 9ef5882 Full report (26 builds for efr32, esp32, nxp, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic and
dhrishi
Co-authored-by: C Freeman <[email protected]>
github-actions
bot
added
the
matter-1.4-te2-script-change
Co-authored-by: C Freeman <[email protected]>
j-ororke
removed
the
matter-1.4-te2-script-change
|
PR #35611: Size comparison from 0b93b0d to eb3a03f Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Updated CI Arguments - Updated dependency location for matter_testing_support - Removed local OpenCommissioningWindow function, updated to using MatterBaseTest version - Removed local CommissioningAttempt function, moved to using function call directly in test - Removed initialization of TH2 controller as not needed - Removed additional dictionary names and delimited it down to just using numbers instead. - Updated matter_testing support script to include setting timeout value dynamically in openCommissioningWindow function
github-actions
bot
added
the
matter-1.4-te2-script-change
Resolving Linting errors
|
PR #35611: Size comparison from 0b93b0d to a9f2650 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Oct 29, 2024
- Moved location of print_step to top of for range for creating virtual fragments - Removed unnecessary print_step for catching error
tehampson
reviewed
Oct 29, 2024
tehampson
reviewed
Oct 29, 2024
tehampson
reviewed
Oct 29, 2024
tehampson
reviewed
Oct 29, 2024
tehampson
reviewed
Oct 29, 2024
tehampson
reviewed
Oct 29, 2024
- Created new variable for current_fabric + 1 - Replaced if statements with asserts.assert_equal() - Changed start of range from 1 to 0 - Changed test steps to match test plan better, removed test step 1
tehampson
approved these changes
Nov 4, 2024
- Added new criteria to test step 3 where max_fabrics is checked to make sure it is greater than initial_fabrics count
- Removed print statement from debugging session
raju-apple
approved these changes
Nov 20, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* [Test] Creating CADMIN 1.19 test module: - Test module created following steps in PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/4669 * Restyled by autopep8 * Update TC_CADMIN_1_19 test module: - Resolving linting issues * Removing yaml test module for TC_CADMIN_1_19: - Removed yaml test as we have created python test module in its place * Update TC_CADMIN_1_19.py - Removed debugging print statements as no longer needed in test code * Update src/python_testing/TC_CADMIN_1_19.py Co-authored-by: C Freeman <[email protected]> * Update src/python_testing/TC_CADMIN_1_19.py Co-authored-by: C Freeman <[email protected]> * Updating TC_CADMIN_1_19 and matter_testing scripts: - Updated CI Arguments - Updated dependency location for matter_testing_support - Removed local OpenCommissioningWindow function, updated to using MatterBaseTest version - Removed local CommissioningAttempt function, moved to using function call directly in test - Removed initialization of TH2 controller as not needed - Removed additional dictionary names and delimited it down to just using numbers instead. - Updated matter_testing support script to include setting timeout value dynamically in openCommissioningWindow function * Restyled by autopep8 * Update TC_CADMIN_1_19.py Resolving Linting errors * Update TC_CADMIN_1_19.py - Moved location of print_step to top of for range for creating virtual fragments - Removed unnecessary print_step for catching error * Updated TC_CADMIN_1_19 test module: - Created new variable for current_fabric + 1 - Replaced if statements with asserts.assert_equal() - Changed start of range from 1 to 0 - Changed test steps to match test plan better, removed test step 1 * Restyled by autopep8 * Updated TC_CADMIN_1_19 test module: - Added new criteria to test step 3 where max_fabrics is checked to make sure it is greater than initial_fabrics count * Updated TC_CADMIN_1_19 test module: - Removed print statement from debugging session * Restyled by autopep8 --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: C Freeman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating python3 TC CADMIN 1.19 test module: